| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <munro(at)ip9(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SKIP LOCKED DATA (work in progress) |
| Date: | 2014-07-29 01:39:14 |
| Message-ID: | 16322.1406597954@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> It might be better if we'd declared AclMode in a single-purpose header,
>> say utils/aclmode.h, and then #include'd that into parsenodes.h.
>> There's certainly plenty of other single-datatype headers laying about.
> Do you mean src/include/datatype/aclmode.h?
I was thinking src/include/utils/, actually, but maybe datatype/ would
be a good choice.
OTOH, what we've got in there now is just timestamp.h, and IIRC it was put
there because it needed to be accessible from both frontend and backend
contexts. That would not be true of aclmode.h, so perhaps aclmode.h
doesn't belong there.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 土卜皿 | 2014-07-29 02:54:08 | whether I can see other alternative plantrees for one query? |
| Previous Message | Alvaro Herrera | 2014-07-29 01:38:41 | Re: [w32] test_shm_mq test suite permanently burns connections slots |