| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber |
| Date: | 2021-11-02 18:36:45 |
| Message-ID: | 1630068.1635878205@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pushed with some adjustment of the comments. I also simplified the
datestyle setting to just "ISO", because that's sufficient: that
DateStyle doesn't care about DateOrder. Since the settings are
supposed to match what pg_dump uses, it's just confusing if they don't.
Also, I didn't commit the test case. It was useful for development,
but it seemed entirely too expensive to keep forevermore compared to its
likely future value. It increased the runtime of 100_bugs.pl by about
a third, and I'm afraid the likely future value is nil. The most likely
bug in this area would be introducing some new GUC that we need to set
and forgetting to do so here; but this test case could not expose that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Samokhvalov | 2021-11-02 18:39:35 | Re: should we enable log_checkpoints out of the box? |
| Previous Message | Andres Freund | 2021-11-02 18:33:31 | Re: Eval expression R/O once time (src/backend/executor/execExpr.c) |