From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: quoting psql varible as identifier |
Date: | 2010-01-04 19:51:03 |
Message-ID: | 162867791001041151w62505b29gfce580ec114220af@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2010/1/4 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>> I have one question. If I understand well, the function fmtId isn't
>> multibyte safe? So why is possible to use it in pg_dump?
>
> pg_dump is only guaranteed to work correctly in the server encoding.
> If you force it to use a client_encoding different from the server's,
> it might or might not work, for reasons far beyond that one --- the
> big problem usually is data containing characters that have no
> equivalent in the client encoding. So I'm not particularly excited
> about whether fmtId is multibyte safe within pg_dump. If we were to try
> to use it in more general contexts, it would probably need more work.
I could agree with this explanation for quote_identifier function, but
not in 100% for fmtId function. We can change encoding for pg_dump
(option -E). I don't have a problem to write second and safe fmtId
function (with technique used in dumputils don't need to modify
libpq), although fmtId do exactly what I need. I would to understand
to behave.
Pavel
>
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2010-01-04 19:51:41 | Re: pg_migrator issues |
Previous Message | Robert Haas | 2010-01-04 19:45:39 | Re: I: TODO: Allow substring/replace() to get/set bit values |