Re: Parsing config files in a directory

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Greg Smith <gsmith(at)gregsmith(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parsing config files in a directory
Date: 2009-10-29 07:11:11
Message-ID: 162867790910290011p12144deev8be1ef29740a9f64@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/10/27 Simon Riggs <simon(at)2ndquadrant(dot)com>:
> On Tue, 2009-10-27 at 00:38 -0400, Greg Smith wrote:
>> new feature
>
> One additional point that would be useful is a way to match up the usage
> of custom_variable_classes with this new style of .conf file processing.
>
> At the moment if you wish to add a custom variable class everybody needs
> to edit the *same* parameter. Finding which one to edit could be a
> little difficult with a whole directory to search in.
>
> I propose a new form of processing for that variable: each new parameter
> instance is added to last one, rather than replacing it.
> e.g.
> custom_variable_class = 'x'
> custom_variable_class = 'y'
> custom_variable_class = 'z'
> is equivalent to
> custom_variable_classes = 'x,y,z'
>
> That allows NewFeatureX to drop in a file called "newfeaturex.conf",
> which looks like this
>
> custom_variable_class = 'newfeaturex'
> newfeaturex.param1 = x
> newfeaturex.param2 = y
> newfeaturex.param3 = z
>
> This requires no editing of any other files, just a straight drop in.
> That will make it much easier to produce real installers/deinstallers
> for add-in modules.

I understand, but this behave is confusing. Maybe better is using some
trivial keywords like append, delete, reset

so
append custom_variable_class = 'x'
append custom_variable_class = 'y'
append custom_variable_class = 'z'

is custom_variable_classes = 'x,y,z'

Regards
Pavel

>
> --
>  Simon Riggs           www.2ndQuadrant.com
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Scott Bailey 2009-10-29 07:31:09 Proposal - temporal contrib module
Previous Message Pavel Stehule 2009-10-29 04:39:58 Re: Syntax for partitioning