Re: WIP: to_char, support for EEEE format

2009/4/21 Brendan Jurd <direvus(at)gmail(dot)com>:
> On Sat, Apr 11, 2009 at 3:51 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> So, please, if you can, propose these error messages (with hints)-
>> result will be much better.
>>
>
> Hi Pavel,
>
> I was doing some work on rewording these error messages, and I noticed
> that the following code segment occurs identically in four different
> locations:
>
>                numstr = orgnum = (char *) palloc(MAXDOUBLEWIDTH + 1);
>                if (Num.pre != 1)
>                        ereport(ERROR,
>                                        (errcode(ERRCODE_SYNTAX_ERROR),
>                                         errmsg("invalid using of format EEEE")));
>

> Rather than rewording all four copies of the message, I wonder if this
> test might be better factored out into a separate function?

maybe macro is better - it is too short and without any semantic for
function, but maybe not. The length of source code is not problem -
the short function will be inlined, so total length will be same. What
should be name for this function or for this macro? It hasn't any
semantic. There should be readable macro only for ereport function -
some

#define RAISE_EEEE_FORMAT_ERROR ereport(ERROR,
(errcode(ERRCODE_SYNTAX_ERROR), errmsg("invalid using of format
EEEE")));

regards
Pavel Stehule

>
> Cheers,
> BJ
>