| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: protect dll lib initialisation against any exception, for 8.5 |
| Date: | 2009-04-02 04:46:26 |
| Message-ID: | 162867790904012146r4c866a95q44e33c252d224f93@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2009/4/2 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>> 2009/4/2 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> So I'm thinking this is really unnecessary and we should leave well
>>> enough alone.
>
>> I see it. I thing , an safety of this exception should be solved only
>> by programmer. It's important to release all hooks, and then raise an
>> exception. It is in developer responsibility.
>
> Well, if the init function is sufficiently carefully coded to back out
> just the changes it's managed to apply, then good for it. But we still
> aren't losing much by leaving dfmgr as-is.
>
Maybe an safe minimum is cleaning symbols table without closing
library. Then the code from lib will be accessible, but functionality
will be disabled (for Postgres)?
regards
Pavel Stehule
> regards, tom lane
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-04-02 04:53:35 | "failed to commit client_encoding" explained |
| Previous Message | Greg Stark | 2009-04-02 04:24:26 | Re: protect dll lib initialisation against any exception, for 8.5 |