| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Keith Fiske <keith(at)omniti(dot)com>, "Daniel O'Connor" <darius(at)dons(dot)net(dot)au>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] BUG #9652: inet types don't support min/max |
| Date: | 2014-06-04 23:10:16 |
| Message-ID: | 16285.1401923416@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-06-03 10:37:53 -0400, Tom Lane wrote:
>> It hasn't even got a comment saying why changes here should
>> receive any scrutiny; moreover, it's not in a file where changes would be
>> likely to excite suspicion. (Probably it should be in opr_sanity, if
>> we're going to have such a thing at all.)
> I've written up the attached patch that moves the test to opr_sanity and
> adds a littlebit of commentary. Will apply unless somebody protests in
> the next 24h or so.
+1, but as long as we're touching this, could we make the output be
SELECT oid::regprocedure, prorettype::regtype FROM pg_proc ...
Same information, but more readable IMO. (I'm not really sure why
we need to show prorettype here at all, btw.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-06-04 23:10:49 | Re: uninterruptable loop: concurrent delete in progress within table |
| Previous Message | Andres Freund | 2014-06-04 23:04:51 | Re: uninterruptable loop: concurrent delete in progress within table |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ali Akbar | 2014-06-04 23:11:37 | Re: "pivot aggregation" with a patched intarray |
| Previous Message | Noah Misch | 2014-06-04 23:07:55 | Re: Sigh, we need an initdb |