Severe regression in autoconf 2.61

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Severe regression in autoconf 2.61
Date: 2008-02-18 23:31:35
Message-ID: 16231.1203377495@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

There seems to have been a bit of a brain cramp upstream :-(.
Previously, AC_FUNC_FSEEKO did this to test if fseeko was available:

return !fseeko;

Now it does this:

return fseeko (stdin, 0, 0) && (fseeko) (stdin, 0, 0);

Unfortunately, that gives the compiler enough of a syntactic clue
to guess that fseeko is probably an undeclared function, and therefore
*it will not error out*, only generate a warning, if it's not seen
a declaration for fseeko.

The proximate result of this in our HEAD is that configure fails to
detect that _LARGEFILE_SOURCE is needed, resulting in a rather broken
build on platforms where that really is needed. I had mis-blamed this
on Bruce's recent NetBSD/BSDi hack, but I think it's been there since
we installed 2.61 autoconf. I suspect that in fact the problem Bruce
was seeing was due to this very bug, and that what we need to do is
revert his BSD-specific patch and find a different solution.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Denne 2008-02-19 01:01:07 Re: Ad Hoc Indexes
Previous Message Justin 2008-02-18 22:13:50 Re: Ad Hoc Indexes