| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Datum should be defined outside postgres.h |
| Date: | 2007-10-25 15:13:02 |
| Message-ID: | 16204.1193325182@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> I fixed it for zic, but problem with ecpg is that it includes
> nodes/primnodes.h and it requires Datum type definition which is defined
> in postgres.h. :(
Why in the world is ecpg including either primnodes.h or postgres.h?
> By my opinion Datum should be defined in separate file and all headers
> which use this type should include it. (this is problem on many places
> with another types). Another question is why ecpg needs it?
Datum is a type that no frontend code has any business dealing in;
and the same goes for everything in primnodes.h.
I'd suggest trying to fix ecpg to not depend on backend-only include
files...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2007-10-25 15:18:00 | Re: Datum should be defined outside postgres.h |
| Previous Message | Tom Lane | 2007-10-25 15:10:17 | Re: text search and "filenames" |