Re: about EncodeDateTime() arguments

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On lr, 2012-03-10 at 18:47 -0500, Tom Lane wrote:
>> It appears to me that null-ness of tzp and tzn are used as a 3-way flag
>> to identify the style of timezone output wanted (none, numeric, or alpha).

> It's not quite a three-way flag, because it also depends on the style,
> which time zone style is used. But I liked the idea of making "print
> the time zone" more explicit and getting rid of the funny pointers. I
> added a bit of documentation and code deduplication in the attached
> patch, and it already looks much more understandable.

Yeah, looks nicer to me too.

Should we propagate this fix into ecpg's copy of the code as well?
I'm not sure how far the backend has diverged from that copy.

regards, tom lane