Re: BUG #15492: pg_cancel_backend(pg_backend_pid()) returns true sporadically

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Law <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15492: pg_cancel_backend(pg_backend_pid()) returns true sporadically
Date: 2018-11-09 14:49:47
Message-ID: 16170.1541774987@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Nov 9, 2018 at 2:21 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> On Thu, Nov 08, 2018 at 11:31:41AM +0100, Magnus Hagander wrote:
>>> ... why is this problem only showing up now?

> Oh, i didn't realize that wasn't run by the buildfarm. Then yeah, it's
> pretty likely it was simply never run.

IIRC, the reason those tests aren't run by default is that they're
pointless unless executed in a hot-standby configuration. I'm inclined to
think we should remove them from src/test/regress altogether, and instead
put equivalent checks (for any not-already-covered case) into one of the
TAP tests that sets up such a configuration. src/test/recovery is
probably the right home.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2018-11-09 15:47:59 BUG #15495: Ldap authentication not working with multiple server in Postgresql 11
Previous Message Magnus Hagander 2018-11-09 14:48:49 Re: BUG #15492: pg_cancel_backend(pg_backend_pid()) returns true sporadically