Re: Should we work around msvc failing to compile tab-complete.c?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should we work around msvc failing to compile tab-complete.c?
Date: 2024-07-09 23:07:24
Message-ID: 1616645.1720566444@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2024-07-09 17:44:27 -0400, Tom Lane wrote:
>> Worst case: the reason no one uses readline under Windows is that it flat
>> out doesn't work.

> It seems to work fine as long as a debug-readline is paired with a debug-psql
> or a release-readline is paired with a release-psql.

OK, cool. I was concerned about the number of options that have to
match according to our PQfreemem docs. But I guess in practice
Windows packagers would likely compile libreadline as part of their
PG build, so that the build options would always match.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-07-09 23:20:12 Re: Built-in CTYPE provider
Previous Message Andres Freund 2024-07-09 22:59:34 Re: Should we work around msvc failing to compile tab-complete.c?