Re: [PATCHES] PATCH: Memory leaks on start-up

From: Lee Kindness <lkindness(at)csl(dot)co(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Lee Kindness <lkindness(at)csl(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] PATCH: Memory leaks on start-up
Date: 2003-07-22 16:10:04
Message-ID: 16157.25052.932860.46049@kelvin.csl.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane writes:
> Lee Kindness <lkindness(at)csl(dot)co(dot)uk> writes:
> > I'd have to disagree with regards to the memory leaks not being worth
> > a mention - any such leak can cause problems when the PostgreSQL
> > installation is either unattended, long-living andor has very high
> > connection levels.
> I don't see how. We are talking about two strings, no more, no less,
> that live for exactly the duration of the postmaster run. Explain to me
> how any of your above conditions will affect this code in the slightest?

For the lock file leak yeah - it's just 2 strings once in a blue
moon. However in the more general case of freeaddrinfo and the eniron
wizardry (which is also leaking, and is done every new instance,
yeah?) it does build up.

Anyway, it's no reason to be lazy/messy, is it?

L.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message scott.marlowe 2003-07-22 16:18:59 Re: php with postgres
Previous Message Bruce Momjian 2003-07-22 16:05:35 Re: tsearch2 for 7.3.X

Browse pgsql-patches by date

  From Date Subject
Next Message Rod Taylor 2003-07-22 16:27:42 Re: Release.sgml markup
Previous Message Bruce Momjian 2003-07-22 15:58:28 Re: ruleutils with pretty-print option