Re: [PATCH] (Windows) psql echoes password when reading from pipe

Matthew Stickney <mtstickney(at)gmail(dot)com> writes:
> The attached is a patch that uses the _fileno/_get_osfhandle approach.
> This doesn't address the stdin fallback, or error handling if opening
> termin fails; however, it should be no worse than what's there now, and
> it fixes the immediate problem.

LGTM; pushed with some cosmetic changes.

> I'm still thinking about the fallback in terms of a mintty-type
> environment, but I wanted to get this patch out there in the meantime.

Yeah. I'm not absolutely sure that we need to do anything there,
given the lack of field complaints; but if we can think of a simple
way to make it more bulletproof, all the better.

regards, tom lane