Re: bad logging around broken restore_command

From: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Subject: Re: bad logging around broken restore_command
Date: 2020-11-19 11:27:29
Message-ID: 160578524963.18283.1120284634467066674.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested

I decided to add my review to this simple patch.
I applied Fuji's patch and found it perfectly working with installcheck-world passed, code is clean.
As for the feature I agree with Jeff and Fuji that this ENOENT case is worth logging under LOG priority.
I consider the last (Fuji's) patch is now ready to be committed.

Best regards,
Pavel Borisov

The new status of this patch is: Ready for Committer

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexey Kondratov 2020-11-19 12:09:42 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Hou, Zhijie 2020-11-19 11:16:42 RE: Parallel copy