From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Dag-Erling Smørgrav <des(at)des(dot)no> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [patch] build issues on Win32 |
Date: | 2010-03-10 15:51:23 |
Message-ID: | 16045.1268236283@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des(at)des(dot)no> writes:
> I've run across a couple of stumbling blocks when building on Win32
> (specifically, XP + MinGW):
> 1. PostgreSQL's private versions of inet_aton etc. can conflict with
> similar functions in other libraries (in my case, PostgreSQL's
> inet_aton conflicts with libavformat's).
So what? We don't link with those libraries. The proposed #defines
seem like a completely bad idea, especially since as-presented they
would affect every platform not only yours. We don't need the
maintenance/debugging headaches of routines that don't have the names
they appear to have.
> ifeq ($(PORTNAME),win32)
> -LIBS += -lws2_32 -lshfolder
> +LIBS += -lws2_32 -lshfolder -lsecur32
> endif
Surely this bit would need to be conditional on whether libsecur32
is available?
> -LDFLAGS="-Wl,--allow-multiple-definition"
> +LDFLAGS="${LDFLAGS} -Wl,--allow-multiple-definition"
That bit seems sane.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-03-10 15:54:07 | Re: renameatt() can rename attribute of index, sequence, ... |
Previous Message | Dag-Erling Smørgrav | 2010-03-10 14:22:14 | [patch] build issues on Win32 |