Quick Links

Re: Fwd: PATCH: Format SQL (external tool)

From:	"J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>
To:	Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc:	Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject:	Re: Fwd: PATCH: Format SQL (external tool)
Date:	2015-05-18 17:01:42
Message-ID:	1601799969.20150518200142@mail.ru
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgadmin-hackers

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html><head><title></title>
<META http-equiv=Content-Type content="text/html; charset=utf-8">
<meta http-equiv="Content-Style-Type" content="text/css">
<style type="text/css"></style>
</head>
<body>

Hi Akshay,
 
fsqlf.exe is the program to use; wx_fsqlf.exe is just a GUI wrapper.
 
I've got the latest version (fsqlf.v0.03-292-gd0fd9bf.zip), and it really fails to run :(
Please try the previous one, it works for me.
<a class=rvts17 href="http://sourceforge.net/projects/fsqlf/files/fsqlf.v0.03/fsqlf.v0.03-141-g94f5a5f.zip.gz/download">http://sourceforge.net/projects/fsqlf/files/fsqlf.v0.03/fsqlf.v0.03-141-g94f5a5f.zip.gz/download</a>
 
Also please note that fsqlf.exe could fail when run in a path containing national characters.
 
 
 
Monday, May 18, 2015, 3:42:11 PM, you wrote:
 
<div><table border=0 cellpadding=1 cellspacing=2>
<tr valign=top>
<td width=12 style="background-color: #0000ff;">
>
</td>
<td width=1038 style="background-color: #ffffff;">
Hi J.F
 
I am reviewing your patch. I have applied the patch and try to test it on Windows 7. Below are the steps that I perform 
<ul style="text-indent: 0px; margin-left: 40px; list-style-position: outside;">
<li>Download SQL Formatter from <a class=rvts8 href="http://fsqlf.sourceforge.net/">http://fsqlf.sourceforge.net/</a></li>
<li>Given the path of fsqlf.exe/wx_fsqlf.exe in File - Options - Query Editor: External formatting utility</li>
<li>I have opened the query tool and wrote some select query. Please refer the attached screenshot for SQL query.</li>
</ul>
When I have given fsqlf.exe in the path it throws the error ( see attached screenshot) and when I have given wx_fsqlf.exe in the path it always report an error "Formatting command did not respond in 3 seconds" in the status bar. 
 
I am not sure how to test it properly. Can you please provide some steps.
 
 
On Mon, May 18, 2015 at 10:10 AM, Akshay Joshi <<a class=rvts10 href="mailto:akshay(dot)joshi(at)enterprisedb(dot)com">akshay(dot)joshi(at)enterprisedb(dot)com</a>> wrote:
 
Sure.
 
 
On Fri, May 15, 2015 at 9:30 PM, Dave Page <<a class=rvts10 href="mailto:dpage(at)pgadmin(dot)org">dpage(at)pgadmin(dot)org</a>> wrote:
 
Akshay, can you take a look please?
 
Thanks.
 
 
On Fri, May 15, 2015 at 4:53 PM, J.F. Oster <<a class=rvts10 href="mailto:jinfroster(at)mail(dot)ru">jinfroster(at)mail(dot)ru</a>> wrote:
> Hello!
>
> Please take a look at the patch.
> Thanks.
>
> Per discussion
> <a class=rvts10 href="http://www.postgresql.org/message-id/CAPyomk5NT9Tm-r3wombLzoY60Vqa+QyRDy4u84_2K9UWLbWHTg@mail.gmail.com">http://www.postgresql.org/message-id/CAPyomk5NT9Tm-r3wombLzoY60Vqa+QyRDy4u84_2K9UWLbWHTg@mail.gmail.com</a>
>
> It's most useful for making readable queries generated by ORMs such as
> Hibernate. But in general, external processing can go far beyond
> formatting task.
>
> I've implemented this feature quick-and-dirty long ago. Finally I made
> myself clean it up, now it looks better, so please consider a patch.
> Tested on Windows 7 and Ubuntu 14.04.
>
> Changes:
> * added new setting, ExtFormatCmd, "External formatting utility" in
>   Options dialogue
> * added menu item "Edit - Format - External Format" in
>   Query editor
> * class sysProcess supports UTF-8 and can pass STDIN for a process.
>
> Suggested use scenario:
> 1. Download and install some SQL formatting utility.
> 2. Tell pgAdmin where it resides:
>    File - Options - Query Editor: External formatting utility.
> 3. Open Query editor. Select a text block to format and press
>    Ctrl-Shift-F. With no selection the whole text gets formatted.
>    In case of non-zero exit code, STDERR will be shown in status bar.
>
> Requirements for external formatting utility:
> * Accepts a STDIN stream and writes result to STDOUT
> * Finishes in less than 3 seconds
> * Exits with code 0 on success
> Support for UTF-8 multibyte characters is preferable.
>
> To see whether it works well, a test can be done:
> C:\> type in.sql |some_formatter >out.sql
> C:\> echo %ERRORLEVEL%
> or
> user(at)linux:~$ cat in.sql |some_formatter >out.sql
> user(at)linux:~$ echo $?
>
> There are few available utilities depending on platform:
>    * Free SQL Formatter (Linux, Windows, Mac OS X(?))
>      <a class=rvts10 href="http://fsqlf.sourceforge.net/">http://fsqlf.sourceforge.net/</a>
>    * Poor Man's T-SQL Formatter (Windows)
>      <a class=rvts10 href="http://architectshack.com/PoorMansTSqlFormatter.ashx">http://architectshack.com/PoorMansTSqlFormatter.ashx</a>
> Also it is possible to make a wrapper script for numerous online
> formatting services, but it's less secure and less reliable.
>
> Fsqlf is FOSS and seems promising. I think of extending it for
> PosgreSQL-specific SQL syntax and probably even PL/pgSQL.
>
>
> --
> Best regards,
>  J.F.
>
>
> --
> Sent via pgadmin-hackers mailing list (<a class=rvts10 href="mailto:pgadmin-hackers(at)postgresql(dot)org">pgadmin-hackers(at)postgresql(dot)org</a>)
> To make changes to your subscription:
> <a class=rvts10 href="http://www.postgresql.org/mailpref/pgadmin-hackers">http://www.postgresql.org/mailpref/pgadmin-hackers</a>
>
 
 
 
--
Dave Page
Blog: <a class=rvts10 href="http://pgsnake.blogspot.com">http://pgsnake.blogspot.com</a>
Twitter: @pgsnake
 
EnterpriseDB UK: <a class=rvts10 href="http://www.enterprisedb.com">http://www.enterprisedb.com</a>
The Enterprise PostgreSQL Company
 
 
 
 
-- 
 
Akshay Joshi
Principal Software Engineer 
 
 
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
 
 
 
 
-- 
 
Akshay Joshi
Principal Software Engineer 
 
 
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
</td>
</tr>
</table>
</div>
 
 
 
 
-- 
Best regards,
 J.F.

</body></html>

Attachment	Content-Type	Size
unknown_filename	text/html	11.6 KB

In response to

Re: Fwd: PATCH: Format SQL (external tool) at 2015-05-18 12:42:11 from Akshay Joshi

Responses

Re: Fwd: PATCH: Format SQL (external tool) at 2015-05-19 07:04:59 from Akshay Joshi

Browse pgadmin-hackers by date

	From	Date	Subject
Next Message	Akshay Joshi	2015-05-19 07:04:59	Re: Fwd: PATCH: Format SQL (external tool)
Previous Message	Priyanka Shendge	2015-05-18 12:51:42	pgAdminIV: reset password functionality