Re: Ryu floating point output patch

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Donald Dong <xdong(at)csumb(dot)edu>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>
Subject: Re: Ryu floating point output patch
Date: 2019-02-17 23:21:56
Message-ID: 15a779de-b67e-3068-461f-1e3dd1aaca6f@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2/17/19 6:15 PM, Andrew Gierth wrote:
>>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> > Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> >> Here's a patch without docco. How much do we actually want to
> >> document this? I'm not sure it has any great value outside of
> >> cross-version upgrade testing.
>
> Tom> I think we have to document it, but it can be fairly terse perhaps.
>
> Tom> Use the specified value of extra_float_digits when dumping
> Tom> floating-point data, rather than pg_dump's default.
>
> Tom> I don't think we need to go into detail about when/why you might
> Tom> want to use it; I can see people thinking of their own reasons.
>
> It should probably at least say that (a) the default is to dump with the
> maximum available precision, and at least hint at (b) that ordinary use
> doesn't require the option. We shouldn't mislead people into thinking
> they need it when they don't.
>

Would you like to reformulate this, then?

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-02-17 23:30:12 Re: 2019-03 CF Summary / Review - Tranche #2
Previous Message Andrew Gierth 2019-02-17 23:15:42 Re: Ryu floating point output patch