| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allow default \watch interval in psql to be configured |
| Date: | 2024-10-09 14:24:27 |
| Message-ID: | 15C5DF31-E2DD-4F42-BC44-12F66F33081A@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 9 Oct 2024, at 16:05, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
Thanks for looking!
> I guess the '1000' was supposed to be the maximum, but ParseVariableDouble doesn't take a maximum.
Doh, I had a max parameter during hacking but removed it since I didn't see a
clear usecase for it. Since it's not an externally published API we can
alwasys add it when there is need. Clearly I managed to generate the patch at
the wrong time without noticing. Fixed.
> That's a little inaccurate: 0 is also accepted, so should be "must be greater than *or equal to* 0". Or maybe "cannot be negative". -0 is also accepted, though.
I changed to "must be at least XX" to keep the message short.
> set -> sets
>
> beetween -> between
Fixed.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Make-default-watch-interval-configurable.patch | application/octet-stream | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2024-10-09 14:28:05 | Re: Use MAX_PARALLEL_WORKER_LIMIT consistently in guc_tables.c |
| Previous Message | Junwang Zhao | 2024-10-09 14:10:27 | Re: general purpose array_sort |