Re: pgsql: Set libpq sslcompression to off by default

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Set libpq sslcompression to off by default
Date: 2018-03-20 04:15:38
Message-ID: 15980.1521519338@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 3/17/18 15:12, Daniel Gustafsson wrote:
>> On 17 Mar 2018, at 17:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Buildfarm reports that SSL_clear_options isn't available everywhere.

>> Per some reading of the documentation and various patchers it seems
>> SSL_clear_options() was introduced in 0.9.8m and SSL_OP_NO_COMPRESSION in
>> 1.0.0.

> It seems the failure is limited to an old NetBSD version. They might
> have patched their libssl locally somehow. Is it worth supporting this?

Dunno, but the other side of the coin is that the goals of this patch
don't seem like a sufficient reason to break backwards compatibility
with any platform.

> We could add a configure test for SSL_clear_options().

Kind of annoying, but ...

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2018-03-20 08:03:35 Re: pgsql: Set libpq sslcompression to off by default
Previous Message Tom Lane 2018-03-20 03:59:41 pgsql: Prevent query-lifespan memory leakage of SP-GiST traversal value