Re: [PATCH] Add section headings to index types doc

From: Jürgen Purtz <juergen(at)purtz(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Subject: Re: [PATCH] Add section headings to index types doc
Date: 2020-08-10 12:52:17
Message-ID: 159706393772.790.11301900224459454375.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed

a) I'm wondering if we should apply one more change to this page. The line-by-line listing of operators occupies much space. What do you think about an inline list (in a separate line) of the operators?

old source:
<simplelist>
<member><literal>&lt;</literal></member>
<member><literal>&lt;=</literal></member>
<member><literal>=</literal></member>
<member><literal>&gt;=</literal></member>
<member><literal>&gt;</literal></member>
</simplelist>

new source:
<synopsis>&lt; &nbsp; &lt;= &nbsp; = &nbsp; &gt;= &nbsp; &gt;</synopsis>
It looks nice in HTML as well as in PDF.

b) I'm in favor of the indentation of all affected lines as it is done in the patch.

The new status of this patch is: Waiting on Author

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2020-08-10 13:45:58 Re: [PATCH] Covering SPGiST index
Previous Message Amit Langote 2020-08-10 11:43:44 Re: problem with RETURNING and update row movement