Re: insert performance for win32

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
Cc: pgsql-performance(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: insert performance for win32
Date: 2005-11-04 18:01:20
Message-ID: 15926.1131127280@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

"Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com> writes:
> Nailed it.

> problem is in mainloop.c -> setup_cancel_handler. Apparently you can
> have multiple handlers and windows keeps track of them all, even if they
> do the same thing. Keeping track of so many system handles would
> naturally slow the whole process down.

Yipes. So we really want to do that only once.

AFAICS it is appropriate to move the sigsetjmp and setup_cancel_handler
calls in front of the per-line loop inside MainLoop --- can anyone see
a reason not to?

I'm inclined to treat this as an outright bug, not just a minor
performance issue, because it implies that a sufficiently long psql
script would probably crash a Windows machine.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2005-11-04 18:07:24 Re: insert performance for win32
Previous Message Kevin Grittner 2005-11-04 17:57:24 Re: [OT] somebody could explain this?

Browse pgsql-performance by date

  From Date Subject
Next Message Merlin Moncure 2005-11-04 18:07:24 Re: insert performance for win32
Previous Message Merlin Moncure 2005-11-04 17:56:02 Re: insert performance for win32