Re: pg_hba.conf - patch to report all parsing errors, and then bail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Selena Deckelmann <selena(at)endpoint(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_hba.conf - patch to report all parsing errors, and then bail
Date: 2009-03-07 18:51:49
Message-ID: 15918.1236451909@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Tom Lane wrote:
>> It sure looks like that's going to try to free new_parsed_lines more
>> than once. Shouldn't clean_hba_list be done just once?

> Yeah, it should be done in the if branch down below. And I think by our
> coding standards (or at least by our conventions), the variable should
> be "ok" and not "OK".

> Unless there are any objections, I can do those cleanups and apply it.

I thought the adjacent comments could do with a bit more wordsmithing,
also, but otherwise that about covers it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2009-03-07 18:56:12 Re: Out parameters handling
Previous Message Magnus Hagander 2009-03-07 18:49:17 Re: pg_hba.conf - patch to report all parsing errors, and then bail