Re: After upgrading libpq, the same function(PQftype) call returns a different OID

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Sebastien Flaesch <sebastien(dot)flaesch(at)4js(dot)com>, Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, M Tarkeshwar Rao <m(dot)tarkeshwar(dot)rao(at)ericsson(dot)com>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
Date: 2025-03-21 18:56:12
Message-ID: 1586473.1742583372@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Thu, Mar 20, 2025 at 2:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> That's documented elsewhere, I believe. For the foo_d.h files,
>> I think it'd be sufficient to do something like 0001 attached.

> WFM. Thanks.

Thanks for looking at it.

>> Also, while checking out the results, I noticed that pg_class.h
>> has an "extern" in the wrong place: it's exposed to client code
>> which can have no use for it. That extern doesn't mention any
>> backend-only typedefs, so it's fairly harmless, but it's still
>> a clear example of somebody not reading the memo. Hence 0002.

> Maybe tack this onto genbki.h?

> diff --git a/src/include/catalog/genbki.h b/src/include/catalog/genbki.h
> index 26e205529d..4a1567a46b 100644
> --- a/src/include/catalog/genbki.h
> +++ b/src/include/catalog/genbki.h
> @@ -146,4 +146,6 @@
> */
> #undef EXPOSE_TO_CLIENT_CODE

> +/* Additional backend-only code is placed after the client-code section. */
> +
> #endif /* GENBKI_H */

Doubt that would help ...

regards, tom lane

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Ron Johnson 2025-03-21 19:00:57 Re: Experience and feedback on pg_restore --data-only
Previous Message Dimitrios Apostolou 2025-03-21 18:36:00 Re: Experience and feedback on pg_restore --data-only