Re: BUG #7588: pgsql 9.1 incompatible with zlib 1.27

John Marino <draco(at)marino(dot)st> writes:
> By the way, I also had to patch 9.1.6 in order to build it with gcc47:
> http://pkgsrc.se/files(dot)php?messageId=20121007102454(dot)6E70D175DD(at)cvs(dot)netbsd(dot)org

[ shrug... ] I just tried 9.1.6 with gcc 4.7.0 and 4.7.2 on Fedora, and
saw nothing but a handful of cosmetic warnings. I see the same on our
buildfarm member anchovy, which is running 4.7.1 on Arch Linux.

We generally don't bother to fix cosmetic warnings introduced by new
toolchains except in HEAD; it's just not worth the trouble. gcc in
particular seems to move the goalposts constantly, and most of the
warnings they've introduced recently are pure pedantry anyway (IMO).

The comments attached to your patches suggest that you saw errors rather
than warnings, but if so you've got distro-specific compiler bugs to
deal with. There is nothing even faintly non-legitimate about the code
chunks you changed.

regards, tom lane