Re: Another typo in comment in setrefs.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Another typo in comment in setrefs.c
Date: 2015-09-10 13:55:55
Message-ID: 15806.1441893355@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Etsuro Fujita (fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp) wrote:
>> I'm attaching a small patch to fix another comment typo in setrefs.c:
>> s/TIDs/OIDs/

> Fixed.

I do not think "typo" is the right characterization. I'm too lazy to
check for sure, but I think what was accumulated was indeed TIDs at one
time. The proposed patch is not correct either: what we accumulate now is
syscache hash values. Might be best to just say "add PlanInvalItems for
user-defined functions", which is the wording used in some other places,
eg line 173.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-09-10 14:24:28 Re: Another typo in comment in setrefs.c
Previous Message Stephen Frost 2015-09-10 13:23:24 Re: Another typo in comment in setrefs.c