Re: (repost) pgtcl: restore 8.0 compatibility for large obj fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ljb <ljb220(at)mindspring(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: (repost) pgtcl: restore 8.0 compatibility for large obj fix
Date: 2003-11-06 03:37:04
Message-ID: 15793.1068089824@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

ljb <ljb220(at)mindspring(dot)com> writes:
> +#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION >= 1 || TCL_MAJOR_VERSION > 8
> + bufObj = Tcl_NewByteArrayObj(buf, nbytes);
> +#else
> bufObj = Tcl_NewStringObj(buf, nbytes);
> +#endif

Hmm. We could certainly do it like that, but does this actually fix the
problem for Tcl 8.0.*? Or will the unwanted character set translation
happen anyway in that version? I don't see any value in letting the
code compile against 8.0.* if the behavior will be wrong ...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2003-11-06 03:57:59 Re: equal() perf tweak
Previous Message Gaetano Mendola 2003-11-06 03:29:59 Re: equal() perf tweak