Re: pgsql: Avoid coercing a whole-row variable that is already coerced.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Avoid coercing a whole-row variable that is already coerced.
Date: 2017-10-12 21:42:01
Message-ID: 1579.1507844521@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Avoid coercing a whole-row variable that is already coerced.

This logic seems very strange and more than likely buggy: the
added coerced_var flag feels like the sort of action at a distance
that is likely to have unforeseen side effects.

I'm not entirely sure what the issue is here, but if you're concerned
about not applying two ConvertRowtypeExprs in a row, why not have the
upper one just strip off the lower one? We handle, eg, nested
RelabelTypes that way.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2017-10-12 22:28:14 Re: pgsql: Fix traversal of half-frozen update chains
Previous Message Robert Haas 2017-10-12 21:16:31 pgsql: Avoid coercing a whole-row variable that is already coerced.