Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery().
Date: 2022-07-21 15:22:48
Message-ID: 15770.1658416968@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> I found that fetch_more_data_begin() in postgres_fdw reports an error when PQsendQuery() returns the value less than 0 as follows though PQsendQuery() can return only 1 or 0. I think this is a bug. Attached is the patch that fixes this bug. This needs to be back-ported to v14 where async execution was supported in postgres_fdw.

Yup, clearly a thinko.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Martin Kalcher 2022-07-21 15:43:02 Re: [PATCH] Introduce array_shuffle() and array_sample()
Previous Message Amit Langote 2022-07-21 15:19:47 Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size