From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | jesper(dot)pedersen(at)redhat(dot)com, Robert Haas <robertmhaas(at)gmail(dot)com>, "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "fabriziomello(at)gmail(dot)com" <fabriziomello(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: pg_upgrade: Pass -j down to vacuumdb |
Date: | 2019-03-26 13:09:19 |
Message-ID: | 15729.1553605759@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2019-03-25 22:57, Tom Lane wrote:
>> + fprintf(script, "echo %sYou may wish to add --jobs=N for parallel analyzing.%s\n",
>> + ECHO_QUOTE, ECHO_QUOTE);
> But then you get that information after you have already started the script.
Yes, but that's already true of all the info that this script prints out.
> I don't find any information about this analyze business on the
> pg_upgrade reference page. Maybe a discussion there could explain the
> different paths better than making the output script extra complicated.
> Essentially: If you want a slow and gentle analyze, use the supplied
> script. If you want a fast analyze, use vacuumdb, perhaps with an
> appropriate --jobs option. Note that pg_upgrade --jobs and vacuumdb
> --jobs are resource-bound in different ways, so the same value might not
> be appropriate for both.
I have no objection to handling it that way (i.e., just as a doc fix).
Or we could do both.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Ila B. | 2019-03-26 13:09:43 | [GSoC 2019] Proposal: Develop Performance Farm Database and Website |
Previous Message | David Rowley | 2019-03-26 12:53:42 | Should the docs have a warning about pg_stat_reset()? |