| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Mason Hale <mason(at)onespot(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: unable to fail over to warm standby server |
| Date: | 2010-01-30 00:18:52 |
| Message-ID: | 15716.1264810732@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Jan 29, 2010 at 3:32 PM, Heikki Linnakangas
>> That only affects the error message and is harmless otherwise, but I
>> thought I'd mention it. I'll fix it, unless someone wants to argue that
>> its more useful to print the raw return value of system(), because it
>> might contain more information like which signal killed the process,
>> that you could extract from the cryptic error code using e.g WTERMSIG()
>> macro.
> An "if" statement would seem to be in order, so that you can print out
> either the exit code or the signal number as appropriate.
Yes. Please see the existing code in the postmaster that prints
subprocess exit codes, and duplicate it (or perhaps refactor so you can
avoid code duplication; though translatability of messages might limit
what you can do there).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2010-01-30 05:43:52 | Re: BUG #5303: Upgrade failure due to sever.key permissions |
| Previous Message | Robert Haas | 2010-01-30 00:07:42 | Re: unable to fail over to warm standby server |