| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value. |
| Date: | 2019-05-21 14:20:57 |
| Message-ID: | 15696.1558448457@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-05-20 20:19:20 -0400, Tom Lane wrote:
>> The other thing I had to do below was to suppress "NOTICE: database
>> "regression" does not exist, skipping". The added createdb is a
>> mighty expensive and grotty way to do that, but I didn't immediately
>> see a better one.
> Hm. Perhaps we ought to just have pg_regress set client_min_messages to
> something less noisy when running DROP DATABASE? I don't think any
> pg_regress caller benefits from having it.
The least invasive way to do that seems to be as attached, building a
little knowledge into pg_regress's psql_command() function. Alternatively
we could add a "bool quiet" parameter to that function so that callers
had to say what to do, but I'm not sure that's an improvement.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| suppress-if-exists-noise-in-pg_regress-1.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-05-21 16:00:20 | Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value. |
| Previous Message | Tom Lane | 2019-05-21 00:52:21 | Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value. |