Re: pgAgent: C++ Port - Patch Review

From: Linreg <linreg(at)gmx(dot)net>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: pgAgent: C++ Port - Patch Review
Date: 2013-10-24 15:52:21
Message-ID: 1566641.1Qb8IbrB6c@wolfclan.ang.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I'll change it. (without prefix!)

Thomas

> > > 1.)
> > >
> > > it is system dependent. On my SUSE system pibpg-header to be installed
> >
> > under
> >
> > > the pgsql directory.
> > >
> > > Example: /usr/include/pgsql/libpq-fe.h
> >
> > What did the previous code do? That worked. Typically we would not
> > expect to see a pgsql/ prefix on a header, but would ensure the
> > compiler is passed the include directory with that directory in it.
>
> Previous code is without pgsql/ prefix on a header. So i think we should
> have only "#include <libpg-fe.h>".
>
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2013-10-25 06:34:13 Re: pgAgent: C++ Port - Patch Review
Previous Message Ashesh Vashi 2013-10-24 11:20:17 Re: PATCH: Improvement in the debugger support for EnterpriseDB <= 9.2