| From: | PG Doc comments form <noreply(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Cc: | ruslan(dot)fomkin(at)gmail(dot)com |
| Subject: | SPI_finish in the case of ereport |
| Date: | 2019-08-20 09:45:21 |
| Message-ID: | 156629432107.1308.3753759498779162858@wrigleys.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/11/spi-spi-finish.html
Description:
Hi,
The documentation of SPI_finish clarifies that aborting with elog will
cleanup SPI automatically without need to call to SPI_finish manually, see
https://www.postgresql.org/account/comments/new/11/spi-spi-finish.html/
On the other side the error reporting is normally done by ereport, while
elog is an old function, which is interchangeable with `ereport` according
to https://www.postgresql.org/docs/11/error-message-reporting.html
If so, can the documentation of SPI_finish mention ereport instead of elog?
(it would be also nice if a regression test is added for this)
Best regards,
Ruslan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-20 10:19:01 | Re: wrong Visual Studio Edition 's name |
| Previous Message | PG Doc comments form | 2019-08-20 07:47:12 | Required locks for ANALYZE |