Re: pgsql: Use new overflow aware integer operations.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Use new overflow aware integer operations.
Date: 2018-02-14 22:36:38
Message-ID: 15638.1518647798@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
>> Yea, that works for me. I wonder if we should choose an absurd sentinel
>> value to prevent code from relying on one? 0x0000beef or such. Unless
>> somebody protests soon-ish I'll make it so.

> Pushed that way (with 0x5EED as the value, seems more appropriate ;)).

LGTM, thanks!

> I can't convince any of my compilers to actual emit warnings in this
> case, so we'll have to see whether prairiedog like this...

Per my results yesterday, locust and coypu were also complaining;
one of them might come back quicker.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-02-14 23:18:14 pgsql: Stabilize new plpgsql_record regression tests.
Previous Message Andres Freund 2018-02-14 22:30:26 Re: pgsql: Use new overflow aware integer operations.