Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
Date: 2022-12-01 14:24:43
Message-ID: 1563756.1669904683@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2022-Dec-01, Noah Misch wrote:
>> This is free from the problem found in ddl-create-public-reorg-really.patch.
>> However, the word "other" doesn't belong there. (The per-user schemas should
>> not have public CREATE privilege.) I would also move that same sentence up
>> front, like this:
>>
>> Constrain ordinary users to user-private schemas. To implement this
>> pattern, first ensure that no schemas have public CREATE privileges.
>> Then, for every user needing to create non-temporary objects, create a
>> schema with the same name as that user. (Recall that the default search
>> path starts with $user, which resolves to the user name. Therefore, if
>> each user has a separate schema, they access their own schemas by
>> default.) This pattern is a secure schema usage pattern unless an
>> untrusted user is the database owner or holds the CREATEROLE privilege, in
>> which case no secure schema usage pattern exists.

> +1 LGTM

Sounds good. I'll make it so in a bit.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-12-01 14:43:00 pgsql: doc: Add installation instructions for building with meson
Previous Message Alvaro Herrera 2022-12-01 11:56:51 pgsql: Move PartitioPruneInfo out of plan nodes into PlannedStmt

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-12-01 14:35:15 Re: [DOCS] Stats views and functions not in order?
Previous Message Avi Weinberg 2022-12-01 13:58:53 Warning When Creating FOR EACH STATEMENT Trigger On Logical Replication Subscriber Side