Re: pgcrypto: Makefile check

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pgcrypto: Makefile check
Date: 2004-11-22 15:46:21
Message-ID: 15633.1101138381@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> This patch makes the pgcrypto Makefile check that a recognized random
> source has been defined. If no such source is defined, pgcrypto will
> compile successfully but will be unusable.

Oh?

> +$(error "Unrecognized random source: $(random)")

Doesn't look like a successful compile to me. What's worse, this would
also cause maintenance operations (like "make clean") to fail.

(I see little point in this anyway given that the makefile defaults to
"random = silly" further up.)

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Fuhr 2004-11-22 16:36:55 Re: another plperl bug
Previous Message Andrew Dunstan 2004-11-22 12:37:46 another plperl bug