Re: pgsql: jit: Re-allow JIT compilation of execGrouping.c hashtable compar

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: jit: Re-allow JIT compilation of execGrouping.c hashtable compar
Date: 2019-09-29 23:54:20
Message-ID: 15612.1569801260@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On September 29, 2019 4:34:14 PM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I've got to say that I'm not very comfortable with changing stuff
>> when we've got less than 24 hours to the 12.0 GA wrap.

> I asked for input on hackers, nobody replied...

Yeah, that was sixty-plus hours ago. I think onlookers said nothing
because they assumed you'd push on Friday, which would have left a
reasonable amount of time for buildfarm testing. Waiting this long
changes the calculus.

Anyway, it's probably going to be all right, but please pay attention
to the calendar when we're hard up against a release date. There
should be a very very good reason to push any code changes this late,
and I don't think "performance regression" qualifies.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2019-09-30 01:21:00 pgsql: Make crash recovery ignore recovery target settings.
Previous Message Michael Paquier 2019-09-29 23:47:33 Re: pgsql: Add libpq parameter 'channel_binding'.