Re: CVS repository invalid revision

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christian Robottom Reis <kiko(at)canonical(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Martin Pitt <martin(at)piware(dot)de>
Subject: Re: CVS repository invalid revision
Date: 2008-02-20 20:22:56
Message-ID: 15612.1203538976@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christian Robottom Reis <kiko(at)canonical(dot)com> writes:
> On Mon, Feb 18, 2008 at 03:13:24PM -0300, Alvaro Herrera wrote:
>> There's no corrupted revision -- the text you see is part of a log
>> message, not a real header line. So the cscvs tool would seem to
>> need to be able to cope with that.

> Wow, that's very interesting. Thanks for pointing it out; now that I
> have this in hand, I need to chase somebody interested in fixing a cscvs
> bug <wink>

I notice that cvsweb doesn't handle it very gracefully, either.

It looks to me like it's just about impossible for anything that
is parsing "cvs log" output to tell the difference between this and
a genuine revision entry header, which means it's probably breaking
most of the other conversion tools too.

Perhaps it'd be worth hacking the CVS repository entries to modify
these log entries a bit? Indenting the quoted revision entry a few
spaces would probably do it.

According to
http://archives.postgresql.org/pgsql-committers/2001-01/msg00115.php
the affected files are contrib/pgcrypto/
md5.c md5.h pgcrypto.c pgcrypto.h sha1.c sha1.h

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-02-20 20:39:24 Re: Permanent settings
Previous Message Gevik Babakhani 2008-02-20 20:15:44 Which MemoryContext?