Re: pg_hba.conf - patch to report all parsing errors, and then bail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Selena Deckelmann <selena(at)endpoint(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_hba.conf - patch to report all parsing errors, and then bail
Date: 2009-03-07 18:28:32
Message-ID: 15584.1236450512@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Selena Deckelmann <selena(at)endpoint(dot)com> writes:
> Currently, load_hba() bails on the first parsing error. It would be
> better for the typo-prone sysadmin if it reported ALL errors, and THEN
> bailed out.

> This patch implements that behavior. Tested against 8.4 HEAD this morning.

It sure looks like that's going to try to free new_parsed_lines more
than once. Shouldn't clean_hba_list be done just once?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2009-03-07 18:49:17 Re: pg_hba.conf - patch to report all parsing errors, and then bail
Previous Message Selena Deckelmann 2009-03-07 18:10:06 pg_hba.conf - patch to report all parsing errors, and then bail