| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Erik Wienhold <ewie(at)ewie(dot)name> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there |
| Date: | 2024-07-25 20:29:11 |
| Message-ID: | 1556597.1721939351@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Erik Wienhold <ewie(at)ewie(dot)name> writes:
> Thanks, I didn't know that guideline. Both fixed in v6.
This still isn't following our usual message style IMO. Here's a
proposed v7 that outputs
-ERROR: type stuff is not a composite type
+ERROR: type stuff is the row type of another table
+DETAIL: A typed table must use a stand-alone composite type created with CREATE TYPE.
I did a bit of copy-editing on the docs changes too. One notable
point is that I dropped the parenthetical bit about "(name optionally
schema-qualified)". That struck me as quite unnecessary, and
it definitely doesn't read well to have two parenthetical comments
in a single four-line sentence.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Document-that-typed-tables-rely-on-CREATE-TYPE.patch | text/x-diff | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-07-25 20:39:44 | Re: [PATCH] Fix docs to use canonical links |
| Previous Message | Jeff Davis | 2024-07-25 20:29:08 | [18] separate collation and ctype versions, and cleanup of pg_database locale fields |