Re: Add Optional Variadic Invocation Explanation to 35.4.5 (xfunc-sql)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: "pgsql-docs(at)postgresql(dot)org" <pgsql-docs(at)postgresql(dot)org>
Subject: Re: Add Optional Variadic Invocation Explanation to 35.4.5 (xfunc-sql)
Date: 2014-12-21 20:35:36
Message-ID: 15559.1419194136@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> This:
> http://www.postgresql.org/docs/9.4/static/xfunc-sql.html
> Describes how to invoke a function defined with VARIADIC with an actual
> array as input instead of supplying ONE-or-more individual arguments to the
> call.

Right, and it does specifically say that there must be at least one
actual argument matching the VARIADIC parameter. Still, an example
to clarify that isn't a bad idea.

> AFAICS the only way to get the called function to see an empty array is to
> call it like:
> SELECT varchar('text fixed 1', VARIADIC ARRAY[]::text[])
> While this is a logical solution to the problem, given the above knowledge,
> it would be nice if both points were made explicitly in the documentation
> in the section linked above.

I did not like your proposed wording, as it seemed to complicate matters
unduly by treating two independent points in the same para. I went with
just adding a separate para instead:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=699300a146c04e207a8fdec407538cdf5368fde5

regards, tom lane

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2014-12-29 15:06:09 The IYYY mess again
Previous Message David Johnston 2014-12-20 01:52:42 libpq "service" parameter not documented as not allowed inside a pg_service file