| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Andrei Zubkov <zubkov(at)moonset(dot)ru>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
| Date: | 2022-04-03 00:30:02 |
| Message-ID: | 1555691.1648945802@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
> The tests for this seem to need adjustments.
> [12:41:09.403] test pg_stat_statements ... FAILED 180 ms
> diff -U3 /tmp/cirrus-ci-build/contrib/pg_stat_statements/expected/pg_stat_statements.out
> /tmp/cirrus-ci-build/contrib/pg_stat_statements/results/pg_stat_statements.out
> --- /tmp/cirrus-ci-build/contrib/pg_stat_statements/expected/pg_stat_statements.out
> 2022-04-02 12:37:42.201823383 +0000
> +++ /tmp/cirrus-ci-build/contrib/pg_stat_statements/results/pg_stat_statements.out
> 2022-04-02 12:41:09.219563204 +0000
> @@ -1174,8 +1174,8 @@
> ORDER BY query;
> query | reset_ts_match
> ---------------------------+----------------
> - SELECT $1,$2 AS "STMTTS2" | f
> SELECT $1 AS "STMTTS1" | t
> + SELECT $1,$2 AS "STMTTS2" | f
> (2 rows)
> -- check that minmax reset does not set stats_reset
> Hm. Is this a collation problem?
Yeah, looks like it. ORDER BY query COLLATE "C" might work better.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2022-04-03 00:45:55 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Greg Stark | 2022-04-03 00:02:07 | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |