Re: Tighten error control for OpenTransientFile/CloseTransientFile

From: Georgios Kokolatos <gkokolatos(at)pm(dot)me>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile
Date: 2019-03-06 14:54:52
Message-ID: 155188409238.16480.11082213460365887952.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Overall the patch looks good and according to the previous discussion fulfils its purpose.

It might be worthwhile to also check for errors on close in SaveSlotToPath().

pgstat_report_wait_end();

CloseTransientFile(fd);

/* rename to permanent file, fsync file and directory */
if (rename(tmppath, path) != 0)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karl O. Pinc 2019-03-06 14:59:31 Re: Patch to document base64 encoding
Previous Message Robert Haas 2019-03-06 14:52:43 Re: [HACKERS] CLUSTER command progress monitor