From: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Bernd Helmle <bernd(dot)helmle(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Progress reporting for pg_verify_checksums |
Date: | 2019-02-18 15:52:48 |
Message-ID: | 1550505168.12689.26.camel@credativ.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Am Montag, den 18.02.2019, 11:18 -0300 schrieb Alvaro Herrera:
> On 2019-Feb-17, Michael Banck wrote:
> > + /*
> > + * As progress status information may be requested, we need to scan the
> > + * directory tree(s) twice, once to get the idea how much data we need to
> > + * scan and finally to do the real legwork.
> > + */
> > + total_size = scan_directory(DataDir, "global", true);
> > + total_size += scan_directory(DataDir, "base", true);
> > + total_size += scan_directory(DataDir, "pg_tblspc", true);
>
> Surely we know at that point whether this first scan is needed, and we
> can skip it if not?
Yeah - new patch attached.
Michael
--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael(dot)banck(at)credativ(dot)de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz
Attachment | Content-Type | Size |
---|---|---|
pg_verify_checksums_progress_V8.patch | text/x-patch | 7.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2019-02-18 15:56:19 | boolean and bool in documentation |
Previous Message | Tom Lane | 2019-02-18 15:43:50 | Re: unconstify equivalent for volatile |