| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: REINDEX CONCURRENTLY 2.0 |
| Date: | 2019-02-07 14:28:05 |
| Message-ID: | 154954968565.11785.6973123402105637191.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: tested, passed
Hello
Sorry for late response. I review latest patch version.
I didn't found any new behavior bugs.
reindex concurrenlty can be in deadlock with another reindex concurrently (or manual vacuum (maybe with wraparound autovacuum) or create index concurrently on same table). But i think this is not issue for this feature, two create index concurrently can be in deadlock too.
Just one small note for documentation:
> +Indexes:
> + "idx" btree (col)
> + "idx_cct" btree (col) INVALID
Second index should be idx_ccnew (or idx_ccold), right?
Code looks good for me.
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2019-02-07 14:33:54 | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Previous Message | REIX, Tony | 2019-02-07 14:18:04 | RE: Shared Memory: How to use SYSV rather than MMAP ? |