Re: pgsql: Add copy/equal support for XID lists

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add copy/equal support for XID lists
Date: 2022-07-12 14:36:45
Message-ID: 1548311.1657636605@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Add copy/equal support for XID lists

What about outfuncs/readfuncs? I see that you fixed _outList,
but not its caller outNode:

else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList))
_outList(str, obj);

and the LEFT_PAREN case in nodeRead() doesn't know what to do either.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-07-12 15:20:59 test_oat_hooks bug (was: Re: pgsql: Add copy/equal support for XID lists)
Previous Message Robert Haas 2022-07-12 14:29:59 pgsql: Rename some functions to mention Relation instead of RelFileLoca

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-07-12 14:39:59 Re: proposal: Allocate work_mem From Pool
Previous Message Robert Haas 2022-07-12 14:30:20 Re: DropRelFileLocatorBuffers