| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Hannu Krosing <hannu(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_system_identifier() |
| Date: | 2013-08-26 20:35:57 |
| Message-ID: | 15419.1377549357@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-08-26 10:10:54 -0700, Josh Berkus wrote:
>> I'm going to reverse my vote, and vote against this patch. The reason
>> why is that I think we should instead have a function:
>>
>> pg_controldata(parameter text)
>>
>> ... which would report *all* strings in pg_controldata. Hence, you'd do
>> instead:
>>
>> pg_controldata('system identifier')
>>
>> This will hopefully spare us from 15 patches incrementally adding all of
>> the individual items in controldata.
> If anything but the proposed feature, it should be an SRF - passing in
> text parameters isn't very discoverable.
I'm not pleased with the idea that we'd have to dumb all the relevant
datatypes down to text so that we could push them through this single
function.
Also, what about i18n? pg_controldata localizes all the strings it
prints, but I doubt that's a great idea for either the input or the
output of this proposed function.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-08-26 20:50:09 | Re: pg_system_identifier() |
| Previous Message | Tom Lane | 2013-08-26 20:31:21 | Re: GetTransactionSnapshot() in enum.c |