Re: pg_restore error message during ENOSPC with largeobj

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: pg_restore error message during ENOSPC with largeobj
Date: 2020-10-18 02:41:43
Message-ID: 153809.1602988903@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> I overflowed my homedir while testing with pg_reload, and got:
> |pg_restore: error: could not write to large object (result: 18446744073709551615, expected: 30)

Bleah.

> I guess casting to long was the best option c. 2002 (commit 6faf8024f) but I
> gather the modern way is with %z.

Isn't the real problem that lo_write returns int, not size_t?

AFAICT, every other call site stores the result in an int,
it's just this one that's out in left field.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-10-18 03:01:42 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Previous Message Hou, Zhijie 2020-10-18 02:17:07 RE: Parallel copy