| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Direct I/O |
| Date: | 2023-04-14 17:21:33 |
| Message-ID: | 1534494.1681492893@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Since the direct I/O commit went in, buildfarm animals
curculio and morepork have been issuing warnings like
hashpage.c: In function '_hash_expandtable':
hashpage.c:995: warning: ignoring alignment for stack allocated 'zerobuf'
in places where there's a local variable of type PGIOAlignedBlock
or PGAlignedXLogBlock. I'm not sure why only those two animals
are unhappy, but I think they have a point: typical ABIs don't
guarantee alignment of function stack frames to better than
16 bytes or so. In principle the compiler could support a 4K
alignment request anyway by doing the equivalent of alloca(3),
but I do not think we can count on that to happen.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2023-04-14 17:34:36 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |
| Previous Message | Laurenz Albe | 2023-04-14 17:15:04 | Re: Should we remove vacuum_defer_cleanup_age? |